Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The merge does not take into account the max confidence level in some cases. #6501

Closed
Lhorus6 opened this issue Mar 27, 2024 · 2 comments
Closed
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)

Comments

@Lhorus6
Copy link

Lhorus6 commented Mar 27, 2024

Description

When I merge several entities, I can modify entities that have a higher confidence than mine:

  • The merge only seems to check the confidence level of the main entity, i.e. the entity I choose as the one I'm going to keep for name, description, etc.
  • If any of the secondary entities have a higher confidence level than mine, that's no problem. The merge is carried out all the same

Environment

OCTI 6.0.8

Reproducible Steps

Steps to create the smallest reproducible scenario:
With an admin user:

  1. Create an Intrusion set "ThreatA" with the conf level at 100
  2. Create an Intrusion set "ThreatB" with the conf level at 40
  3. Create a user with confidence level at 50 and the capabilities to update knowledge

Log in with the new user with conf level at 50

  1. Go to Data > Entities
  2. Select ThreatA and ThreatB
  3. Merge them by selecting ThreatB as the main entity
    -> The merge is done
@Lhorus6 Lhorus6 added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 27, 2024
@SamuelHassine SamuelHassine added this to the Release 6.0.9 milestone Mar 28, 2024
@jborozco
Copy link
Member

Duplicate of 6502

@nino-filigran nino-filigran added duplicate use to identify issue already existing and removed needs triage use to identify issue needing triage from Filigran Product team labels Mar 28, 2024
@Lhorus6
Copy link
Author

Lhorus6 commented Mar 28, 2024

Hi @jborozco,

No, that's not the same. The other issue is that when you can't merge two entities, a background task is created in any case, but it has no effect, and no error is raised.

Here I'm saying that merge is done in certain cases, when it shouldn't be.

@Lhorus6 Lhorus6 reopened this Mar 28, 2024
@Kedae Kedae added needs triage use to identify issue needing triage from Filigran Product team and removed duplicate use to identify issue already existing labels Mar 28, 2024
@Jipegien Jipegien removed the needs triage use to identify issue needing triage from Filigran Product team label Mar 28, 2024
@Jipegien Jipegien modified the milestones: Release 6.0.9, Release 6.1.0 Mar 28, 2024
@SarahBocognano SarahBocognano self-assigned this Mar 29, 2024
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Apr 6, 2024
@SamuelHassine SamuelHassine modified the milestones: Release 6.1.0, Release 6.0.10 Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

No branches or pull requests

7 participants