Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix No error when merging two entities with a higher confidence level (#6502) #6565

Merged
merged 3 commits into from Apr 5, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Remove the filter that was implemented before in the background task to avoid error. We want to display an error now
  • Move the check of confidence low level in middleware (mergeEntities) instead of the function that compute the list task

Related issues

@SarahBocognano SarahBocognano self-assigned this Apr 4, 2024
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.58%. Comparing base (cff70c3) to head (ecc10b8).
Report is 8 commits behind head on master.

Files Patch % Lines
...tform/opencti-graphql/src/domain/backgroundTask.js 33.33% 2 Missing ⚠️
...latform/opencti-graphql/src/manager/taskManager.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6565      +/-   ##
==========================================
+ Coverage   67.76%   68.58%   +0.81%     
==========================================
  Files         532      532              
  Lines       65069    65048      -21     
  Branches     5464     5964     +500     
==========================================
+ Hits        44097    44613     +516     
+ Misses      20972    20435     -537     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano changed the title [backend] Fix No error when merging two entities with a higher confidence level (#issue/6502) [backend] Fix No error when merging two entities with a higher confidence level (#6502) Apr 4, 2024
@SarahBocognano SarahBocognano merged commit a6741ed into master Apr 5, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6502 branch April 20, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants