Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets that use the entity color might end up unreadable #6521

Closed
labo-flg opened this issue Mar 29, 2024 · 1 comment · Fixed by #6595
Closed

Widgets that use the entity color might end up unreadable #6521

labo-flg opened this issue Mar 29, 2024 · 1 comment · Fixed by #6595
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)

Comments

@labo-flg
Copy link
Member

If you create a Donut widget on markings, the widget will use the color of the markings as colors inside the chart.

Howevre, the labels in the tooltips are rendered on top of this fixed color, and it might end up white-on-white which is unreadable.

image

@labo-flg labo-flg added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 29, 2024
@SamuelHassine SamuelHassine added this to the Release 6.0.9 milestone Mar 30, 2024
@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Apr 2, 2024
@SamuelHassine SamuelHassine modified the milestones: Release 6.0.9, Release 6.0.10 Apr 3, 2024
@lndrtrbn lndrtrbn self-assigned this Apr 5, 2024
@lndrtrbn
Copy link
Member

lndrtrbn commented Apr 5, 2024

This one is a bit tricky as the lib ApexChart does not offer in its API the possibility to change text color in tooltip. You need to either target the text in the tooltip with CSS or create a complete custom tooltip.

I don't think the CSS targeting solution will work because we cannot define dynamically the color depending on the data we are hovering in the chart. So it means recreate a complete tooltip. We can take advantage of this solution to create a tooltip that looks more like the other tooltips we have in the app with OpenCTI UI.

@SamuelHassine SamuelHassine modified the milestones: Release 6.0.10, Release 6.1.0 Apr 8, 2024
@lndrtrbn lndrtrbn linked a pull request Apr 9, 2024 that will close this issue
5 tasks
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants