Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playbook] The drop-down menu doesn't show everything #6581

Closed
Lhorus6 opened this issue Apr 4, 2024 · 7 comments · Fixed by #6686
Closed

[Playbook] The drop-down menu doesn't show everything #6581

Lhorus6 opened this issue Apr 4, 2024 · 7 comments · Fixed by #6686
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)

Comments

@Lhorus6
Copy link

Lhorus6 commented Apr 4, 2024

Description

The drop-down menu in the "manipulate knowledge" component does not display all available statuses, even when using the search function.

Environment

OCTI 6.0.8

Reproducible Steps

Before making the repro case, you need to have several status set up on your platform. For example, set 3 - 4 statuses on 5 different entities (otherwise, go directly to the testing platform).

Steps to create the smallest reproducible scenario:

  1. Create a playbook and add a "manipulate knowledge" component
  2. Try to replace a status -> you won't find all the statuses. Neither by scrolling nor by searching

Screenshots

Screenshot 2024-04-04 184323

@Lhorus6 Lhorus6 added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Apr 4, 2024
@jborozco jborozco removed the needs triage use to identify issue needing triage from Filigran Product team label Apr 5, 2024
@SamuelHassine SamuelHassine modified the milestones: Release 6.0.10, Release 6.1.0 Apr 6, 2024
@marieflorescontact marieflorescontact self-assigned this Apr 10, 2024
@marieflorescontact
Copy link
Member

the statuses listed are those used in entities workflows. If they exist in the status template but are not used, they are not listed. In my opinion, this is not a bug. @jborozco

@marieflorescontact marieflorescontact added the needs more info Intel needed about the use case label Apr 11, 2024
@jborozco
Copy link
Member

@marieflorescontact I double checked, actually we don't see all status mapped for exemple in testing, incidents have 4 statuses:

image

But in the playbook I only see one
image

@SamuelHassine
Copy link
Member

SamuelHassine commented Apr 12, 2024

As we discussed multiple times with @richard-julien, @Jipegien and @Kedae, in the filters / dropdown choices of triggers, dashboard widgets, playbooks, CSV feeds, TAXII collections etc. we should display ALL possible statuses, labels, assignees etc. even if they are not used anywhere in the platform. Users cannot wait for something to be used to be able to set alerting, automation, dashboards or feeds.

If not all statuses are displayed here, this is definitely a bug.

@lndrtrbn
Copy link
Member

Lhorus6

component does not display all available statuses

SamuelHassine

we should display ALL possible statuses

We need more information to understand what you want. What means "all available statuses" ? All the statuses defined in taxonomies ? All statuses defined in workflows (even if they are not present of any entities for now) ?

The query is already working but we limit the result to 10 items for now. Still there is an other issue that leads to errors. In the dropdown we have multiple times each entities with different statuses. For example if we retake our use case of Incidents @jborozco on testing, first we have:
image
And below in the list we have:
image

Should we not have all status regrouped in one block for each entities?

@lndrtrbn lndrtrbn added the needs more info Intel needed about the use case label Apr 16, 2024
@Jipegien
Copy link
Member

If following status are define for the entityA: new, in progress, closed, blabla -> so "new", "in progress", "closed" and "blabla" must be selectable in filters, regardless of their usage. An automation must be configurable on all possibilities, even if it is not yet used in the platform. Like triggers.

Beware though: there is a subject regarding "users" (used in assignee, participants, author). see @labo-flg about it

@labo-flg
Copy link
Member

Indeed, as for filters on users, we need to enforce organization segregation : a user should not be able to see users outside of their organization.
I've done some quick changes few months back in useSearchEntities so that people can always see themselves (using the me object) in these filters, but I've not addressed the whole issue.

@frapuks
Copy link
Member

frapuks commented Apr 17, 2024

@lndrtrbn

Should we not have all status regrouped in one block for each entities?

This issue is reported here : #6585
And this PR fix it : #6707

@SamuelHassine SamuelHassine added solved use to identify issue that has been solved (must be linked to the solving PR) and removed needs more info Intel needed about the use case labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants