Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User can create entities with blank names #6698

Closed
labo-flg opened this issue Apr 15, 2024 · 0 comments · Fixed by #6722
Closed

User can create entities with blank names #6698

labo-flg opened this issue Apr 15, 2024 · 0 comments · Fixed by #6722
Assignees
@lndrtrbn
Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.0.10

Comments

@labo-flg
Copy link
Member

labo-flg commented Apr 15, 2024 •
edited

Description

We can create entities with name made of blank characters only.
This has unexpected side effects in the code afterwards, and might impact negatively things like platforms synchronization.

Environment

6.0.9

Reproducible Steps

  • Create a report with 2 spaces as a name
  • go to details, check out the query
  • name is returned blank ""

Expected Output

Error: backend side (invalid name), frontend side (create/edit form).
Also, make sure this check is also done when ingesting from streams and co.

Actual Output

No error.
@labo-flg labo-flg added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Apr 15, 2024
@SamuelHassine SamuelHassine added critical use to identify critical bug to fix ASAP and removed needs triage use to identify issue needing triage from Filigran Product team labels Apr 15, 2024
@lndrtrbn lndrtrbn self-assigned this Apr 16, 2024
@SamuelHassine SamuelHassine added this to the Release 6.1.0 milestone Apr 17, 2024
@lndrtrbn lndrtrbn mentioned this issue Apr 17, 2024
Merged
5 tasks
@lndrtrbn lndrtrbn linked a pull request Apr 17, 2024 that will close this issue
[frontend] Yup trim before validation for required string (#6698) #6722
Merged
5 tasks
lndrtrbn added a commit that referenced this issue Apr 17, 2024
@lndrtrbn
[frontend] Yup trim before validation for required string (#6698)
e37f6e7
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lndrtrbn lndrtrbn

Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.0.10
Development

Successfully merging a pull request may close this issue.

[frontend] Yup trim before validation for required string (#6698) OpenCTI-Platform/opencti
3 participants
@SamuelHassine @lndrtrbn @labo-flg