Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend not updated properly when adding a user to a group #6703

Closed
SamuelHassine opened this issue Apr 16, 2024 · 2 comments · Fixed by #6721
Closed

Frontend not updated properly when adding a user to a group #6703

SamuelHassine opened this issue Apr 16, 2024 · 2 comments · Fixed by #6721
Assignees
@Archidoit
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.0.10

Comments

@SamuelHassine
Copy link
Member

Description

  1. Go to a group
  2. Open edition
  3. Go in members
  4. Check a box

=> The box is never checked, you have to full refresh
@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Apr 16, 2024
@Kedae Kedae removed the needs triage use to identify issue needing triage from Filigran Product team label Apr 16, 2024
@Archidoit Archidoit self-assigned this Apr 16, 2024
@SamuelHassine SamuelHassine added this to the Release 6.1.0 milestone Apr 17, 2024
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] update frontend when adding a user to a group (#6703)
c4eba0a
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] update frontend when adding a user to a group (#6703)
c7ac408
@Archidoit Archidoit mentioned this issue Apr 17, 2024
Merged
@Archidoit Archidoit linked a pull request Apr 17, 2024 that will close this issue
[frontend] update frontend when adding a user to a group (#6703) #6721
Merged
@labo-flg
Copy link
Member

I stumbled upon this bug recently, here's some insights:

  • The query is sucessful
  • frontend has issues with duplicated keys in the user list in GroupEditionUsers, which could explain the UI
  • if you refresh, all is ok.
  • if you DONT refresh and go to the page groups, you'll get an error. In fact you'll get an error everywhere in the app: relay is basically crashed because of interlaced updater calls (the error logs points to the updater in GroupEditionUsers, on the add user mutation

Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] improvement (#6703)
2a860e5
@Archidoit
Copy link
Member

Yes, the problem comes from the updater that throws an error (because incorrect pagination options are given).

Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] deepscan (#6703)
dc3bdd2
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] update frontend when adding a user to a group (#6703)
ee5cc68
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] update frontend when adding a user to a group (#6703)
1dac4be
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] improvement (#6703)
780eee3
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] deepscan (#6703)
c968837
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] fix after review (#6703)
493ff8d
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] fix styles (#6703)
a89ecf3
Archidoit added a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] improvement (#6703)
8a2e21f
SamuelHassine pushed a commit that referenced this issue Apr 17, 2024
@Archidoit
[frontend] update frontend when adding a user to a group (#6703)
9d759a2
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Archidoit Archidoit

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.0.10
Development

Successfully merging a pull request may close this issue.

[frontend] update frontend when adding a user to a group (#6703) OpenCTI-Platform/opencti
4 participants
@SamuelHassine @Kedae @Archidoit @labo-flg