-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV feeds screen broken after deleting the CSV mapper #6757
Comments
Cascade delete seems to be the issue. What do we want ? We can prevent and throw an error when trying to delete a mapper that has ingester(s) using it ; meaning the user has to delete or reconfigure all ingesters before being able to delete the mapper. OR We cascade delete : when deleting a mapper all ingesters using it are deleted also. IMO this means we should add a confirmation popup when deleting the mapper, warning that "N ingesters are currently using it, are you sure?". |
The second option would not prevent the error to happen again right? I mean potentially a user could confirm both pop up and we would still be in the same situation, right? If so, I'm more in favor of the first solution. |
The second option would prevent the error because we would delete also all ingesters using this mapper, so the ingestion/feed page would not crash. |
I think I would still prefer the first option, because if the user has a CSV feed ingester using the specific CSV mapper, the user might delete it which would cause the CSV feed to not work anymore. And I guess we're not letting the user know that something is wrong with a CSV feed. |
Ok, agreed. Let's throw an error when deleting a mapper used by one or more ingesters. If we need a more complex approach, let's discuss it in time. |
Description
On testing instance: https://testing.octi.staging.filigran.io/dashboard/data/ingestion/csv.
I think, given the errors, is the CSV mapper associated to one of the CSV feed has been deleted.
The text was updated successfully, but these errors were encountered: