Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External reference URL are not properly validated during creation #7431

Closed
JeremyCloarec opened this issue Jun 20, 2024 · 1 comment
Closed
Assignees
Labels
bug use for describing something not working as expected ingestion Linked to ingestion (manual, from file, feeds & queue) solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@JeremyCloarec
Copy link
Contributor

Description

The validation doesn't recognize some valid URLs.
URLs in the form of http://localhost:4000/storage/get/* are not accepted for exemple, as well as ftp addresses.

Environment

  1. OS (where OpenCTI server runs): { e.g. Mac OS 10, Windows 10, Ubuntu 16.4, etc. }
  2. OpenCTI version: { e.g. OpenCTI 1.0.2 }
  3. OpenCTI client: { e.g. frontend or python }
  4. Other environment details:

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Go to External references
  2. Click on create an external ref
  3. Set URL to http://localhost:4000/storage/get/blabla.txt

Expected Output

URL is validated

Actual Output

We get a message saying that 'The value must be an URL'

Additional information

Screenshots (optional)

@JeremyCloarec JeremyCloarec added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Jun 20, 2024
@Archidoit
Copy link
Member

Other scenario :

Create an entity with a file. The external ref is well created.
Click on Update the external ref :
image

Change the source name. An error occurs for the URL field :
image

But the external ref is well updated if we leave the edition form :
image

@romain-filigran romain-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Jun 21, 2024
@nino-filigran nino-filigran added this to the Bugs backlog milestone Jun 24, 2024
@SarahBocognano SarahBocognano self-assigned this Jun 28, 2024
@Jipegien Jipegien added the ingestion Linked to ingestion (manual, from file, feeds & queue) label Jul 1, 2024
SarahBocognano added a commit that referenced this issue Jul 8, 2024
…reation (#7431)

Co-authored-by: Samuel Hassine <samuel.hassine@filigran.io>
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected ingestion Linked to ingestion (manual, from file, feeds & queue) solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

No branches or pull requests

7 participants