Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for more Special Characters in RabbitMQ Password #957

Closed
ayman-m opened this issue Dec 21, 2020 · 0 comments · Fixed by #958
Closed

Support for more Special Characters in RabbitMQ Password #957

ayman-m opened this issue Dec 21, 2020 · 0 comments · Fixed by #958
Labels
dependencies use for pull requests that update a dependency file feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 4.0.4

Comments

@ayman-m
Copy link
Contributor

ayman-m commented Dec 21, 2020

Please replace every line in curly brackets { like this } with appropriate answers, and remove this line.

Problem to Solve

Havving an '@' in the rabbitmq user password causes a problem as it is misinterpreted as pre-host special character in "amqp://${user}:${pass}@${host}:${port}"

Current Workaround

Not to use @ in rabbitmq user password

Proposed Solution

An update to support more special characters in the chosen rabbitmq admin password, by passing the credentials as a connect socket option instead of passing them part of the connect URL

Additional Information

Will submit a PR shortly
@ayman-m ayman-m mentioned this issue Dec 21, 2020
Merged
@SamuelHassine SamuelHassine added dependencies use for pull requests that update a dependency file feature use for describing a new feature to develop labels Dec 22, 2020
SamuelHassine pushed a commit that referenced this issue Dec 22, 2020
@ayman-m
[api] Support for more Special Characters in RabbitMQ Password (#957)
afef67c
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Dec 22, 2020
@SamuelHassine SamuelHassine added this to the Release 4.0.4 milestone Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies use for pull requests that update a dependency file feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 4.0.4
Development

Successfully merging a pull request may close this issue.

An update to support more special characters in the chosen rabbitmq a… my-soc/opencti
2 participants
@SamuelHassine @ayman-m