Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in 'agent' role #2364

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Conversation

febrezo
Copy link
Contributor

@febrezo febrezo commented Sep 18, 2022

Proposed changes

  • A minor change in the usage of the term agent which has a typo without the initial a

image

Related issues

N/A

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Note that the behaviour for systems that may be using the old gent term has not been tested. I'm not technically capable of addressing to what extent the DB consistency might be an issue here.

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Base: 71.75% // Head: 71.76% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (3952745) compared to base (f267f8d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2364      +/-   ##
==========================================
+ Coverage   71.75%   71.76%   +0.01%     
==========================================
  Files         236      236              
  Lines       15082    15082              
  Branches     2445     2445              
==========================================
+ Hits        10822    10824       +2     
+ Misses       3694     3692       -2     
  Partials      566      566              
Impacted Files Coverage Δ
...tform/opencti-graphql/src/graphql/sseMiddleware.js 61.24% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SamuelHassine SamuelHassine merged commit 1025465 into OpenCTI-Platform:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants