Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand list of Event types #2393

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

mattreduce
Copy link
Contributor

Proposed changes

  • Alphabetize the list of Event types
  • Add these types of events relevant for intelligence:
    • conference to cover conferences/symposia/large meetings that aren't international summits
    • financial can mean an IPO, merger, acquisition, earnings report, or other significant financial event
    • holiday could mean a holiday like Independence Day in the United States, a day when work or school are closed (which could correlate with attacker activity), or a day of religious or national significance to incorporate into analysis

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Thank you! Let me know if you have any questions, or if I should take this opportunity to add other types of Events.

Alphabetize list, add these types of events relevant for intelligence:

- conference
- financial
- holiday
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 71.72% // Head: 71.74% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (ff455b8) compared to base (b919888).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
+ Coverage   71.72%   71.74%   +0.01%     
==========================================
  Files         236      236              
  Lines       15064    15064              
  Branches     2439     2439              
==========================================
+ Hits        10805    10807       +2     
+ Misses       3692     3690       -2     
  Partials      567      567              
Impacted Files Coverage Δ
...tform/opencti-graphql/src/graphql/sseMiddleware.js 61.24% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SamuelHassine
Copy link
Member

Thanks a lot @mattreduce for this PR!

@SamuelHassine SamuelHassine merged commit 9360e36 into OpenCTI-Platform:master Sep 29, 2022
@mattreduce mattreduce deleted the add-event-types branch April 30, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants