Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Filters support multiples keys to search on (#2435) #2444

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Oct 12, 2022

We can query multiple keys in GraphQL, for example filters: [{ key: [name, aliases], values: ["Alias1"] }]

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 71.70% // Head: 71.74% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (267e6cc) compared to base (c60f7eb).
Patch coverage: 89.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2444      +/-   ##
==========================================
+ Coverage   71.70%   71.74%   +0.03%     
==========================================
  Files         237      237              
  Lines       15344    15360      +16     
  Branches     2481     2485       +4     
==========================================
+ Hits        11003    11020      +17     
  Misses       3764     3764              
+ Partials      577      576       -1     
Impacted Files Coverage Δ
.../opencti-graphql/src/database/middleware-loader.ts 83.01% <ø> (ø)
...ncti-platform/opencti-graphql/src/domain/status.ts 66.00% <ø> (ø)
...ti-platform/opencti-graphql/src/database/engine.js 83.86% <76.92%> (+0.03%) ⬆️
...cti-platform/opencti-graphql/src/database/redis.ts 82.13% <100.00%> (+0.04%) ⬆️
...-platform/opencti-graphql/src/generated/graphql.ts 100.00% <100.00%> (ø)
...ti-platform/opencti-graphql/src/http/httpServer.js 73.86% <100.00%> (-0.30%) ⬇️
...tform/opencti-graphql/src/graphql/sseMiddleware.js 60.92% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kedae Kedae changed the title Issue/2435 Filters on "name" should also look into aliases #2435 Oct 12, 2022
@richard-julien richard-julien changed the title Filters on "name" should also look into aliases #2435 Filters on "name" should also look into aliases (#2435) Oct 12, 2022
@Kedae Kedae linked an issue Oct 12, 2022 that may be closed by this pull request
@richard-julien richard-julien changed the title Filters on "name" should also look into aliases (#2435) [api] Filters support multiples keys to search on (#2435) Oct 12, 2022
@richard-julien richard-julien merged commit bc4f4c4 into master Oct 12, 2022
@richard-julien richard-julien deleted the issue/2435 branch October 15, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[api] Filters support multiples keys to search on
2 participants