Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api/front] Bump librairies + adapt front testing #2458

Merged
merged 7 commits into from
Oct 14, 2022
Merged

Conversation

richard-julien
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 71.69% // Head: 71.67% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1481747) compared to base (0f74f67).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1481747 differs from pull request most recent head 268a8a6. Consider uploading reports for the commit 268a8a6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2458      +/-   ##
==========================================
- Coverage   71.69%   71.67%   -0.03%     
==========================================
  Files         237      237              
  Lines       15388    15383       -5     
  Branches     2497     2496       -1     
==========================================
- Hits        11033    11026       -7     
- Misses       3777     3779       +2     
  Partials      578      578              
Impacted Files Coverage Δ
...cti-platform/opencti-graphql/src/graphql/schema.js 87.39% <100.00%> (-0.51%) ⬇️
...tform/opencti-graphql/src/graphql/sseMiddleware.js 60.50% <0.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.


return `module.exports = ${assetFilename};`;
},
return { code }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test that, but not sure it is working anymore as you change the return type ? It was a string and is now a object ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to JEST new version

};

export default R.compose(inject18n, withStyles(styles))(Profile);
export default Profile;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would have been a great time to convert it to tsx :)


test('renders without crashing', async () => {
const environment = createMockEnvironment();
// eslint-disable-next-line arrow-body-style
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should correct it instead of disabling

@richard-julien richard-julien merged commit e37a4d1 into master Oct 14, 2022
@richard-julien richard-julien deleted the tool/upgrade branch October 14, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants