-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api/front] Bump librairies + adapt front testing #2458
Conversation
Codecov ReportBase: 71.69% // Head: 71.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2458 +/- ##
==========================================
- Coverage 71.69% 71.67% -0.03%
==========================================
Files 237 237
Lines 15388 15383 -5
Branches 2497 2496 -1
==========================================
- Hits 11033 11026 -7
- Misses 3777 3779 +2
Partials 578 578
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
||
return `module.exports = ${assetFilename};`; | ||
}, | ||
return { code } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to test that, but not sure it is working anymore as you change the return type ? It was a string and is now a object ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to JEST new version
}; | ||
|
||
export default R.compose(inject18n, withStyles(styles))(Profile); | ||
export default Profile; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would have been a great time to convert it to tsx :)
|
||
test('renders without crashing', async () => { | ||
const environment = createMockEnvironment(); | ||
// eslint-disable-next-line arrow-body-style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should correct it instead of disabling
1481747
to
2f146f9
Compare
No description provided.