Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Add support of content_ref in Stix file for Artifact #2468

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Oct 18, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 71.78% // Head: 71.84% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (b5c0bdb) compared to base (22326e0).
Patch coverage: 88.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2468      +/-   ##
==========================================
+ Coverage   71.78%   71.84%   +0.06%     
==========================================
  Files         238      238              
  Lines       15534    15540       +6     
  Branches     2516     2518       +2     
==========================================
+ Hits        11151    11165      +14     
+ Misses       3802     3795       -7     
+ Partials      581      580       -1     
Impacted Files Coverage Δ
...-platform/opencti-graphql/src/generated/graphql.ts 100.00% <ø> (ø)
.../opencti-graphql/src/schema/stixCyberObservable.js 100.00% <ø> (ø)
...encti-graphql/src/resolvers/stixCyberObservable.js 51.51% <60.00%> (-0.05%) ⬇️
.../opencti-graphql/src/domain/stixCyberObservable.js 45.32% <88.23%> (+0.25%) ⬆️
...ncti-platform/opencti-graphql/src/database/stix.ts 89.90% <89.47%> (+4.19%) ⬆️
...latform/opencti-graphql/src/database/middleware.js 81.94% <100.00%> (+0.25%) ⬆️
...orm/opencti-graphql/src/database/stix-converter.ts 64.44% <100.00%> (ø)
...opencti-graphql/src/schema/stixCoreRelationship.ts 100.00% <100.00%> (ø)
...phql/src/schema/stixCyberObservableRelationship.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kedae Kedae force-pushed the issue/2414 branch 5 times, most recently from dc133b9 to f5b1459 Compare October 19, 2022 15:42
@richard-julien
Copy link
Member

Early remarks

UI modification for content_ref is missing
stixCyberObservableEdit > addRelation (del ..._ are not working. (not related to this task but could be fixed)

@Kedae Kedae force-pushed the issue/2414 branch 6 times, most recently from 3f80150 to 17fe8e8 Compare October 25, 2022 10:06
@richard-julien richard-julien merged commit ee459ec into master Oct 25, 2022
@richard-julien richard-julien deleted the issue/2414 branch October 25, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants