[frontend] Adapt overview of objects lowering ID importance (#1781) #2489
Conversation
Codecov ReportBase: 72.25% // Head: 72.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2489 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 250 250
Lines 16050 16050
Branches 2580 2580
=======================================
Hits 11597 11597
Misses 3867 3867
Partials 586 586 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -131,9 +131,14 @@ const ThemeDark = ( | |||
| borderTopRightRadius: 'inherit', | |||
| }, | |||
| pre: { | |||
| fontFamily: 'Consolas, monaco, monospace', | |||
There was a problem hiding this comment.
Est-ce que l'on a un système de variable pour centraliser les fonts ? (et est-ce que ce serait utile ?)
Afin d'utiliser la variable $font-consolas et $font-IBM pour '"IBM Plex Sans", sans-serif'
| }, | ||
| popover: { | ||
| float: 'left', | ||
| marginTop: '-13px', |
There was a problem hiding this comment.
On a pas mal de marginTop: '-13px' dans le code, je sais pas si du coup en passant à 12 ce sera bien alignés avec tous les autres composants ? (j'ai aucune idée de là où ils s'affichent ->
There was a problem hiding this comment.
En effet c'est le cas, Je remet a 13 :)
| @@ -2,3 +2,5 @@ import * as R from 'ramda'; | |||
|
|
|||
| export const isNotEmptyField = <T>(field: T | null | undefined): field is T => !R.isEmpty(field) && !R.isNil(field); | |||
| export const isEmptyField = <T>(field: T | null | undefined): field is null | undefined => !isNotEmptyField(field); | |||
|
|
|||
| export const copyToClipboard = (text: string) => navigator.clipboard.writeText(text); | |||
There was a problem hiding this comment.
Je n'ai pas l'impression que cette fonction soit utilisée
There was a problem hiding this comment.
En effet :) Je vais modifier pour l'utiliser
richard-julien
force-pushed
the
issue/1781
branch
from
e694de1
to
33a9340
Compare
| @@ -2,3 +2,5 @@ import * as R from 'ramda'; | |||
|
|
|||
| export const isNotEmptyField = <T>(field: T | null | undefined): field is T => !R.isEmpty(field) && !R.isNil(field); | |||
| export const isEmptyField = <T>(field: T | null | undefined): field is null | undefined => !isNotEmptyField(field); | |||
|
|
|||
| export const copyToClipboard = (text: string) => navigator.clipboard.writeText(text); | |||
| color: '#ffffff !important', | ||
| background: `${accent || '#01478d'} !important`, | ||
| }, | ||
| 'pre.light': { | ||
| fontFamily: 'Consolas, monaco, monospace', | ||
| background: `${nav || '#071a2e'} !important`, |
There was a problem hiding this comment.
Note for the future: we should prevent '!important'
Proposed changes
Related issues