Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api/frontend] Truncate history message when they are too long (#2470) #2494

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Oct 26, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 72.28% // Head: 72.30% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (7133038) compared to base (b0fb143).
Patch coverage: 80.00% of modified lines in pull request are covered.

❗ Current head 7133038 differs from pull request most recent head e84e01f. Consider uploading reports for the commit e84e01f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2494      +/-   ##
==========================================
+ Coverage   72.28%   72.30%   +0.02%     
==========================================
  Files         250      250              
  Lines       15968    15966       -2     
  Branches     2568     2568              
==========================================
+ Hits        11543    11545       +2     
+ Misses       3841     3837       -4     
  Partials      584      584              
Impacted Files Coverage Δ
opencti-platform/opencti-graphql/src/domain/log.js 36.66% <0.00%> (+0.30%) ⬆️
...cti-platform/opencti-graphql/src/database/utils.js 95.06% <88.88%> (+0.02%) ⬆️
...tform/opencti-graphql/src/graphql/sseMiddleware.js 60.84% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SamuelHassine SamuelHassine changed the title [api/front] Truncate history message when they are too long [api/front] Truncate history message when they are too long (#2470) Oct 27, 2022
@SamuelHassine SamuelHassine changed the title [api/front] Truncate history message when they are too long (#2470) [api/frontend] Truncate history message when they are too long (#2470) Nov 5, 2022
@richard-julien richard-julien merged commit 594bfed into master Nov 6, 2022
@richard-julien richard-julien deleted the issue/2470 branch November 6, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit the history message length both in backend (when inserting) and frontend
2 participants