Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api/frontend] Remove entities after report deletion (#1468) #2524

Merged
merged 5 commits into from
Nov 7, 2022

Conversation

SamuelHassine
Copy link
Member

@SamuelHassine SamuelHassine commented Oct 29, 2022

Proposed changes

Related issues

@SamuelHassine SamuelHassine linked an issue Oct 29, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 72.30% // Head: 72.32% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (0d6a78e) compared to base (81e20fe).
Patch coverage: 50.98% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2524      +/-   ##
==========================================
+ Coverage   72.30%   72.32%   +0.02%     
==========================================
  Files         250      250              
  Lines       15968    16062      +94     
  Branches     2568     2615      +47     
==========================================
+ Hits        11545    11617      +72     
- Misses       3839     3861      +22     
  Partials      584      584              
Impacted Files Coverage Δ
...-platform/opencti-graphql/src/generated/graphql.ts 100.00% <ø> (ø)
...m/opencti-graphql/src/modules/grouping/grouping.ts 100.00% <ø> (ø)
...ncti-platform/opencti-graphql/src/domain/report.js 81.35% <45.00%> (-18.65%) ⬇️
...i-platform/opencti-graphql/src/resolvers/report.js 94.73% <50.00%> (-2.57%) ⬇️
...ti-platform/opencti-graphql/src/database/engine.js 83.29% <54.16%> (-0.67%) ⬇️
.../opencti-graphql/src/database/middleware-loader.ts 85.71% <60.00%> (-1.00%) ⬇️
...tform/opencti-graphql/src/graphql/sseMiddleware.js 60.42% <0.00%> (-0.43%) ⬇️
opencti-platform/opencti-graphql/src/domain/log.js 38.23% <0.00%> (+1.87%) ⬆️
...cti-platform/opencti-graphql/src/database/utils.js 97.13% <0.00%> (+2.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Add query script support + search counting
@richard-julien richard-julien merged commit c6bc165 into master Nov 7, 2022
@richard-julien richard-julien deleted the issue/1468 branch November 7, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove entities after report deletion
2 participants