Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api/frontend] Enhance search screen with table and number of reports (#2336, #2263) #2557

Merged
merged 10 commits into from
Nov 14, 2022

Conversation

SamuelHassine
Copy link
Member

@SamuelHassine SamuelHassine commented Nov 14, 2022

Proposed changes

  • [api/frontend] Enhance search screen with table and number of reports ()

Related issues

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 65.38% // Head: 65.38% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (242c78c) compared to base (30f712d).
Patch coverage: 64.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2557      +/-   ##
==========================================
- Coverage   65.38%   65.38%   -0.01%     
==========================================
  Files         262      262              
  Lines       16359    16406      +47     
  Branches     3234     3234              
==========================================
+ Hits        10697    10727      +30     
- Misses       5662     5679      +17     
Impacted Files Coverage Δ
...rm/opencti-graphql/src/resolvers/stixCoreObject.js 34.78% <0.00%> (-2.43%) ⬇️
...tform/opencti-graphql/src/domain/stixCoreObject.js 33.33% <20.00%> (-1.71%) ⬇️
...ti-platform/opencti-graphql/src/database/engine.js 85.27% <100.00%> (+0.01%) ⬆️
...-platform/opencti-graphql/src/generated/graphql.ts 100.00% <100.00%> (ø)
...tform/opencti-graphql/src/schema/stixCoreObject.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SamuelHassine SamuelHassine marked this pull request as ready for review November 14, 2022 03:15
@Kedae
Copy link
Member

Kedae commented Nov 14, 2022

Not sure to understand the bevavior. In the platform I have multiple objects with the same name (one file, one sector and one event) and if I bulk search by the name it only gets me the file ?

@SamuelHassine
Copy link
Member Author

Not sure to understand the bevavior. In the platform I have multiple objects with the same name (one file, one sector and one event) and if I bulk search by the name it only gets me the file ?

Fixed.

@SamuelHassine SamuelHassine merged commit be3b8da into master Nov 14, 2022
@SamuelHassine SamuelHassine deleted the issue/2336 branch November 14, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk search of SDOs and SCOs Ability to search OpenCTI for a list of Observables (as opposed to one by one)
2 participants