Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] Add Outcome connector handling and introduce Webhooks #3707

Merged
merged 1 commit into from
Aug 13, 2023
Merged

[backend/frontend] Add Outcome connector handling and introduce Webhooks #3707

merged 1 commit into from
Aug 13, 2023

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Jul 10, 2023 •
edited

Co-authored-by: Julien Richard julien.richard@filigran.io

Outcome connectors can be registered on the platform with a schema.
The admin can creates new Outcomes based on those connector and define specific fields based on their schema.
Specified members can use those outcomes in their triggers to receive their notifications

@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Jul 10, 2023
@Kedae Kedae linked an issue Jul 10, 2023 that may be closed by this pull request
Implement webhooks in the notification manager #2850
Closed
@RomuDeuxfois
Copy link
Member

Can we have more inputs for this work ?
We don't have any brainstorm or issue to rely on.

Thank you :)

@Kedae
Copy link
Member Author

Kedae commented Jul 11, 2023 •
edited by Jipegien

Can we have more inputs for this work ? We don't have any brainstorm or issue to rely on.

Thank you :)

Ok it's not a huge one, but you mean like that : [Redacted]

SouadHadjiat
SouadHadjiat reviewed Jul 11, 2023
View reviewed changes
opencti-platform/opencti-graphql/src/modules/outcome/outcome.graphql Outdated
outcome_connector: OutcomeConnector!
outcome_connector_id: String!
outcome_configuration: String!
authorized_members: [MemberAccess!] @auth(for: [SETTINGS])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could it be named authorizedMembers ? not to be confused with the stored field "authorized_members". Same for outcomeConnector

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am waiting to discuss it with Julien to get know what is the rule of naming we want

@Kedae
Copy link
Member Author

Kedae commented Jul 11, 2023 •
edited

Some update to make:

  • Rename Outcome to notifier
  • Add Notifier creation/edition in the activity feed
  • Add a test button with notification and activity
  • Add stix knowledge data as string and the same as object to the notifier (or even send the all notification object)
  • Remove the trigger page from notification
  • Edit documentation -> [docs] Add documentation for notifiers and connectors docs#42

@Kedae Kedae marked this pull request as draft July 11, 2023 15:37
@Kedae Kedae force-pushed the issue/2850 branch 5 times, most recently from 42e7268 to a5a4629 Compare August 1, 2023 07:32
@Kedae Kedae marked this pull request as ready for review August 1, 2023 08:38
RomuDeuxfois
RomuDeuxfois reviewed Aug 3, 2023
View reviewed changes
opencti-platform/opencti-graphql/src/modules/notification/notification.ts Show resolved Hide resolved
opencti-platform/opencti-graphql/tests/02-integration/04-manager/notificationManager-test.js Show resolved Hide resolved
...atform/opencti-front/src/private/components/settings/notifications/notifier/NotifierLine.tsx Outdated Show resolved Hide resolved
...rm/opencti-front/src/private/components/settings/notifications/notifier/NotifierCreation.tsx Show resolved Hide resolved
...orm/opencti-front/src/private/components/settings/notifications/notifier/NotifierPopover.tsx
}
`;

const NotifierPopover = ({ data, paginationOptions }: { data: NotifierLine_node$data, paginationOptions?: NotifierLinesPaginationQuery$variables }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entity number is not update when we delete a notifier
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an issue we have everywhere in the platform :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue to track that ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, not have been a pain yet.

opencti-platform/opencti-front/src/utils/Localization.js Show resolved Hide resolved
opencti-platform/opencti-graphql/graphql-codegen.yml Show resolved Hide resolved
opencti-platform/opencti-graphql/graphql-codegen.yml Show resolved Hide resolved
opencti-platform/opencti-graphql/src/manager/notificationManager.ts Outdated Show resolved Hide resolved
opencti-platform/opencti-graphql/src/modules/notifier/notifier.ts Show resolved Hide resolved
@Kedae Kedae force-pushed the issue/2850 branch 5 times, most recently from da22a8c to c5a47e7 Compare August 7, 2023 13:14
@Kedae
Copy link
Member Author

Kedae commented Aug 7, 2023

All comments have been answered

@RomuDeuxfois
Copy link
Member

The sort doesn't work on notifier
image

@Kedae Kedae force-pushed the issue/2850 branch 2 times, most recently from 7488a91 to ad74af5 Compare August 9, 2023 13:15
@Kedae
Copy link
Member Author

Kedae commented Aug 10, 2023

All good

@helene-nguyen
Copy link
Member

Tested locally and all good :)

@Kedae Kedae force-pushed the issue/2850 branch 2 times, most recently from 8110a26 to d80d72f Compare August 11, 2023 08:59
@Kedae
[backend/frontend] Add Outcome connector handling and introduce Webhooks
eadce09 
Co-authored-by: Julien Richard <julien.richard@filigran.io>
@Kedae Kedae merged commit fc581f9 into master Aug 13, 2023
6 checks passed
@Kedae Kedae deleted the issue/2850 branch August 13, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouadHadjiat SouadHadjiat SouadHadjiat left review comments

@marieflorescontact marieflorescontact marieflorescontact left review comments

@RomuDeuxfois RomuDeuxfois RomuDeuxfois approved these changes

@helene-nguyen helene-nguyen helene-nguyen approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement webhooks in the notification manager
5 participants
@Kedae @RomuDeuxfois @helene-nguyen @SouadHadjiat @marieflorescontact