Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/2559 Display all indicators/observables contained in reports which contain a specific entity(#2559) #3764

Merged
merged 55 commits into from
Aug 2, 2023

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Jul 13, 2023

This is the 1st part of the issue applied to the Threat Actor Individual, once approved we will extend it to the rest of the entities concerned.

Related Brainstorm

Explanation of code structure and opening on the next step

Proposed changes

  • Remove Indicators tab from the knowledge Topbar
  • Indicators are now accesible from the knowledge right bar above Observables
  • Add contextual view that displays Observables/Indicators that are contained in Reports/Case/Grouping that contains the Entity
  • Create reusable view component to display EntistixCorerelationships : EntitiesView / RelationshipView / ContextualView
  • Add filtering on Pattern Type and Indicator type for Indicators entities view

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Jul 17, 2023
@RomuDeuxfois RomuDeuxfois force-pushed the issue/2559 branch 3 times, most recently from 3d97215 to daea399 Compare July 25, 2023 12:45
@RomuDeuxfois RomuDeuxfois marked this pull request as ready for review July 25, 2023 14:31
@yassine-ouaamou yassine-ouaamou self-requested a review July 26, 2023 08:44
Copy link
Member

@yassine-ouaamou yassine-ouaamou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding a relationship with indicators, if we do it from "Entities view", we have the possiblity to create "indicates" or "related to" relationships.
If done from "Relationships views", only "indicates" is possible.
possible relationships

Is it normal?

@yassine-ouaamou
Copy link
Member

yassine-ouaamou commented Jul 26, 2023

  • The columns are misaligned in the "Entites view"

image

  • In the "Relationship view", the links to the indicators are broken.
  • "Related entities" seems to be broken too. Maybe it's just me

@marieflorescontact
Copy link
Member Author

PR status

  • all previous comments have been taken into account.

1 new issue to be fixed:

  • It crashes when sorting by relationship_type on the relationship view and switching to the contextual view

@marieflorescontact
Copy link
Member Author

PR status

  • all previous comments have been taken into account.
  • bug on ordering fixed

PR ready for review

@Archidoit
Copy link
Member

Overview of a threat actor individual: bad display of 'details' (content of 'goals' in the second column whereas the 'goals' title is in the first one, bad seperation after the '-' of description...) :
image

@Archidoit
Copy link
Member

Archidoit commented Aug 1, 2023

  • in a threat actor individual > Knowledge > Indicator > contextual view : bad alignement of the selection squares:
    image

  • missing translation: 'Relationships view'
    image

@@ -85,7 +85,6 @@ type ThreatActorIndividual implements BasicObject & StixObject & StixCoreObject
filters: [StixCoreRelationshipsFiltering]
filterMode: FilterMode
): [Distribution] @auth(for: [KNOWLEDGE, EXPLORE])
# StixDomainObject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put back this comment, please?

@RomuDeuxfois
Copy link
Member

PR status

  • all previous comments have been taken into account.

PR ready for review 🔥 🔥 🔥

@RomuDeuxfois RomuDeuxfois merged commit 1861183 into master Aug 2, 2023
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/2559 branch August 2, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants