Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Be able to add images in overview of some entity types (#issue/2540) #3797

Merged
merged 19 commits into from
Jul 27, 2023

Conversation

SarahBocognano
Copy link
Member

Proposed changes

This issue will be in multiple parts:

  • First part : Add Carousel in Overview and Add Images in Cards
  • Second Part : Implements the picture managment section
  • Add a carousel in overview of the Threat Actors Individuals with pictures uploaded in the data section
  • Add picture to cards of Threat Actors Individual if at least one is uploaded in the data section
  • Add a picture managment section (empty for now but will come in PR2)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@SarahBocognano SarahBocognano self-assigned this Jul 19, 2023
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Jul 19, 2023
@SarahBocognano
Copy link
Member Author

Update: All comments have been resolved.

@SarahBocognano
Copy link
Member Author

Update: Method name's changed. All is good, waiting for approuval

@SouadHadjiat
Copy link
Member

Tested locally :

  • I can add images to a Threat Actor individual in Data -> uploaded files, and I can see them displayed in the details overview (as carousel) and in the list view (the first image) 👍

@SarahBocognano SarahBocognano merged commit a71d024 into master Jul 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants