Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Close dialog on create/update opinion #3839

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Jul 24, 2023

Informations

Not able to reproduce in local, only in Filigran instance.
So, need to be retest after merge in Filigran instance.

Proposed changes

  • Add missing handleClose

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jul 24, 2023
@RomuDeuxfois RomuDeuxfois merged commit 1918c1c into master Jul 25, 2023
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/3838 branch July 25, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants