Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] fix Malware analyses names in Cases/Analyses "Entities" view #3847

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[frontend] fix Malware analyses names in Cases/Analyses "Entities" view #3847

merged 1 commit into from
Jul 27, 2023

Conversation

yassine-ouaamou
Copy link
Member

Proposed changes

  • Fixed the names of Malware analyses in the "Entities" view of Cases and Analyses entities

Related issues

@yassine-ouaamou yassine-ouaamou linked an issue Jul 27, 2023 that may be closed by this pull request
When adding a malware analysis via Analysis or Cases/Entities, name is not displayed in the search result #3845
Closed
@yassine-ouaamou yassine-ouaamou self-assigned this Jul 27, 2023
@yassine-ouaamou yassine-ouaamou added the filigran team use to identify PR from the Filigran team label Jul 27, 2023
@yassine-ouaamou yassine-ouaamou marked this pull request as ready for review July 27, 2023 12:03
@SarahBocognano
Copy link
Member

Tested: The bug is resolved ✅

I have notice that we can't create an entity of type malware analysis in the knowledge section. Can you also fix this ? ^^

Capture d’écran (53)

@yassine-ouaamou
Copy link
Member Author

Tested: The bug is resolved ✅

I have notice that we can't create an entity of type malware analysis in the knowledge section. Can you also fix this ? ^^

Capture d’écran (53)

Thanks for the feedback @SarahBocognano! I will speak with Jean-Philippe about this.
Can you approve the PR, please?

@yassine-ouaamou yassine-ouaamou merged commit f1a8d8d into master Jul 27, 2023
6 checks passed
@yassine-ouaamou yassine-ouaamou deleted the issue/3845 branch July 27, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahBocognano SarahBocognano SarahBocognano approved these changes

Assignees

@yassine-ouaamou yassine-ouaamou

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When adding a malware analysis via Analysis or Cases/Entities, name is not displayed in the search result
2 participants
@yassine-ouaamou @SarahBocognano