Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix global search infinite loading and total count (#3882) #3883

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Jul 31, 2023

Proposed changes

  • fix renaming of stixCoreObjects to globalSearch

Related issues

Infinite loading for global search results was not working anymore and entities total count was always 0 (/dashboard/search)

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat marked this pull request as ready for review July 31, 2023 09:04
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jul 31, 2023
@RomuDeuxfois
Copy link
Member

Still have some problems :

  • Not possible to retrieve all entities
  • We don't have the number of total result

@SouadHadjiat
Copy link
Member Author

Still have some problems :

  • Not possible to retrieve all entities
  • We don't have the number of total result

What do you mean ? I just tested again, and I can see the results number and when I scroll, I can see all the results. Could you give me more details ?

Capture d'écran 2023-08-01 104319

@RomuDeuxfois
Copy link
Member

Still have some problems :

  • Not possible to retrieve all entities
  • We don't have the number of total result

What do you mean ? I just tested again, and I can see the results number and when I scroll, I can see all the results. Could you give me more details ?

Capture d'écran 2023-08-01 104319

My apologies, I didn't refresh my browser completely after the build.
Everything is good on my side!

@SouadHadjiat SouadHadjiat merged commit 6da27de into master Aug 1, 2023
6 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/3882 branch August 1, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the number of search results is large, they are not displayed on the screen.
2 participants