Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] fix missing definition for stix cyber observables relationships (#3865) #3885

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[backend] fix missing definition for stix cyber observables relationships (#3865) #3885

merged 1 commit into from
Aug 1, 2023

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Jul 31, 2023 •
edited

Proposed changes

  • definitions should take into account abstract stix cyber observables

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat linked an issue Jul 31, 2023 that may be closed by this pull request
Crash during creation of links between an Infrastructure and IPv4 addresses #3865
Closed
@SouadHadjiat SouadHadjiat marked this pull request as ready for review July 31, 2023 13:24
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jul 31, 2023
@SouadHadjiat SouadHadjiat added this to the Release 5.10.0 milestone Jul 31, 2023
@yassine-ouaamou yassine-ouaamou self-requested a review August 1, 2023 06:40
@RomuDeuxfois RomuDeuxfois merged commit 3f99350 into master Aug 1, 2023
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/3865 branch August 1, 2023 07:48
@SamuelHassine SamuelHassine removed this from the Release 5.10.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomuDeuxfois RomuDeuxfois RomuDeuxfois approved these changes

@Archidoit Archidoit Archidoit approved these changes

@yassine-ouaamou yassine-ouaamou Awaiting requested review from yassine-ouaamou

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash during creation of links between an Infrastructure and IPv4 addresses
4 participants
@SouadHadjiat @RomuDeuxfois @Archidoit @SamuelHassine