Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Be able to hide Observables, Artifacts and Sightings (#3642) #3889

Merged
merged 26 commits into from
Aug 11, 2023

Conversation

yassine-ouaamou
Copy link
Member

@yassine-ouaamou yassine-ouaamou commented Aug 1, 2023

Proposed changes

  • Possibility to hide Observables, Artifacts and Sightings
  • Possibility to hide the sections Observations and Events (and Analyses)
  • Artifact and Observable appear now in the Settings > Customization page and the only setting we can configure for them is "Hidden Entity" (no workflow, no custom attributes)

Related issues

@marieflorescontact
Copy link
Member

marieflorescontact commented Aug 3, 2023

Bugs found:

  • when trying to update hidden entities for default role, app crashes: (

    • edit default role
    • add hidden entities
    • edit again to remove hidden entities ==> app crashes (locally not on demo)
  • Different behaviour with/without Bypass
    -with ByPass user : When hidden entities Analyses (reports/Groupings/Malware Analyses/) are selected, the Analyses section is still visible in the leftbar but empty .
    -with standard user: Analyses section is not visible in the leftbar
    (maybe it is normal, i just find it weird)

Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs founds:

  • Same as Romuald, for the sightings in hidden entities list and the behavior when removing incident (the top bar hilight the observed data instead of sightings)

I tested the bugs of Marie, didn't succed to reproduce them. It works fine on my screen.

@@ -34,6 +34,7 @@ export interface BasicStoreEntityEntitySetting extends BasicStoreEntity {
platform_hidden_type: boolean;
enforce_reference: boolean;
attributes_configuration?: string;
workflow_configuration: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand how workflow_configuration is set. It is not saved in the database, how do we use it exactly ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is saved in the database as we initialize the entity settings on the startup of the platform (initialization.js:platformInit.js -> initCreateEntitySettings())

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't see it in my database. Do you ? @yassine-ouaamou

From what I can see, initCreateEntitySettings creates entity settings only if they are not already in the database (which won't work for existing platforms, or only if the entity type is new).
And it creates the entitySetting based on defaultEntitySetting, which doesn't have workflow_configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! It is not on the database.

@SouadHadjiat
Copy link
Member

I guess "Workflow Status" icon should be displayed in grey for Artifact and Observables since it's not available

Capture d'écran 2023-08-03 170249

@yassine-ouaamou
Copy link
Member Author

I guess "Workflow Status" icon should be displayed in grey for Artifact and Observables since it's not available

Capture d'écran 2023-08-03 170249

Fixed!

@yassine-ouaamou
Copy link
Member Author

Bugs found:

  • when trying to update hidden entities for default role, app crashes: (

    • edit default role
    • add hidden entities
    • edit again to remove hidden entities ==> app crashes (locally not on demo)
  • Different behaviour with/without Bypass
    -with ByPass user : When hidden entities Analyses (reports/Groupings/Malware Analyses/) are selected, the Analyses section is still visible in the leftbar but empty .
    -with standard user: Analyses section is not visible in the leftbar
    (maybe it is normal, i just find it weird)

I am not able to reproduce any of these two behaviours

@yassine-ouaamou
Copy link
Member Author

Last review planned for tomorrow with Julien

@yassine-ouaamou yassine-ouaamou force-pushed the issue/3642 branch 2 times, most recently from a39b1a1 to 5e0dfc2 Compare August 9, 2023 08:51
@yassine-ouaamou
Copy link
Member Author

All the feedbacks have been fixed!
Ready to merge if someone approves

@RomuDeuxfois
Copy link
Member

We don't have the same traslation for
image
image

@yassine-ouaamou
Copy link
Member Author

We don't have the same traslation for image image

Done!

@Archidoit
Copy link
Member

all good :)

@yassine-ouaamou yassine-ouaamou merged commit 91b71af into master Aug 11, 2023
6 checks passed
@yassine-ouaamou yassine-ouaamou deleted the issue/3642 branch August 11, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to fully hide "Observations" (missing: Observables / Artifacts) and "Events" (missing: Sightings)
6 participants