-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] Be able to hide Observables, Artifacts and Sightings (#3642) #3889
Conversation
cfaeea3
to
b652fed
Compare
3709ce1
to
5cd5892
Compare
Bugs found:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugs founds:
- Same as Romuald, for the sightings in hidden entities list and the behavior when removing incident (the top bar hilight the observed data instead of sightings)
I tested the bugs of Marie, didn't succed to reproduce them. It works fine on my screen.
@@ -34,6 +34,7 @@ export interface BasicStoreEntityEntitySetting extends BasicStoreEntity { | |||
platform_hidden_type: boolean; | |||
enforce_reference: boolean; | |||
attributes_configuration?: string; | |||
workflow_configuration: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand how workflow_configuration
is set. It is not saved in the database, how do we use it exactly ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is saved in the database as we initialize the entity settings on the startup of the platform (initialization.js:platformInit.js -> initCreateEntitySettings())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still can't see it in my database. Do you ? @yassine-ouaamou
From what I can see, initCreateEntitySettings
creates entity settings only if they are not already in the database (which won't work for existing platforms, or only if the entity type is new).
And it creates the entitySetting based on defaultEntitySetting
, which doesn't have workflow_configuration
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right! It is not on the database.
5cd5892
to
ada5701
Compare
I am not able to reproduce any of these two behaviours |
Last review planned for tomorrow with Julien |
a39b1a1
to
5e0dfc2
Compare
All the feedbacks have been fixed! |
… + update migration script
90d246b
to
9b8f480
Compare
...rm/opencti-graphql/src/migrations/1691569743543-add-entity-setting-workflow_configuration.js
Show resolved
Hide resolved
all good :) |
Proposed changes
Related issues