Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Enable notifications mass deletion for all users (#3506) #3913

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Aug 3, 2023

@Archidoit Archidoit self-assigned this Aug 3, 2023
@Archidoit Archidoit marked this pull request as draft August 3, 2023 10:15
@Archidoit Archidoit linked an issue Aug 3, 2023 that may be closed by this pull request
@Archidoit Archidoit force-pushed the issue/3506 branch 2 times, most recently from 2b39681 to a4fc2c6 Compare August 4, 2023 07:17
@Archidoit Archidoit marked this pull request as ready for review August 4, 2023 12:28
@Archidoit Archidoit marked this pull request as draft August 7, 2023 07:58
@Archidoit Archidoit marked this pull request as ready for review August 7, 2023 08:27
label={label}
/>
);
default:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't go there right ?
We have User and Knowledge, that's all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right but 'switch' should have a default case... maybe I should rather throw an Error?

@Archidoit Archidoit merged commit 8db0514 into master Aug 8, 2023
2 of 5 checks passed
@Archidoit Archidoit deleted the issue/3506 branch August 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable notifications mass deletion for all roles
2 participants