Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix default confidence #3932

Merged
merged 1 commit into from
Aug 4, 2023
Merged

[frontend] Fix default confidence #3932

merged 1 commit into from
Aug 4, 2023

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Aug 4, 2023

Proposed changes

  • Handle default confidence in context of container
  • Handle default confidence, author and markins when missing :
    • create observable from container observables tab
    • create SDO from container entities tab
    • create Stix Object/relationship from container linked entities

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Aug 4, 2023
@Archidoit
Copy link
Member

working well :)

@SamuelHassine SamuelHassine merged commit 76ff794 into master Aug 4, 2023
6 checks passed
@SamuelHassine SamuelHassine deleted the issue/3921 branch August 4, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression on default values when creating entities in the context of a container
3 participants