Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] improve relationships distribution query (#3844) #3996

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Aug 7, 2023

Proposed changes

  • Fix targeted country dashboard query (we didn't return only countries ids, but also entities ids related to the countries, and return 100 results instead of 20)
  • Set query results to 0 for aggregations (we only need aggregations), and use the limit param for aggregations size
  • Add toRole param to have a more accurate filter (instead of *_to)

Related issues

There is a performance issue with relations distribution query which can result to a timeout

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality => works locally, but I can't test the perf since I only have a small db
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Aug 10, 2023
@helene-nguyen
Copy link
Member

Tested locally and all good :)

@richard-julien richard-julien merged commit 870f081 into master Aug 24, 2023
6 checks passed
@richard-julien richard-julien deleted the issue/3844 branch August 24, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants