[backend/frontend] Be able to add images in overview of some entity types (#issue/2540)

[SarahBocognano]

This issue is the following of Threat Actor Individual Image Carousel. Now we can manage the pictures uploaded in the Data Section, select their order in the carousel, add a description and choose if we want it to be in the carousel or not.

Proposed changes

• Add a picture management section to be able to order, add description and select carousel selection or not

Related issues

• Be able to add images in overview of some entity types #2540

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[yassine-ouaamou]

Here are some feedbacks we can talk about tomorrow:

• Last History is unreadable
  

• No limit in Image size (maybe store thumbnails or smaller version and show it because loading a 15Mo picture takes time)

• Alignment of cells in picture management
  

• "In Carousel" checkbox becomes false after editing Description or Order

[Archidoit]

When we click in the overview of a threat actor individual, the image displayed is the first one, but the points at the bottom don't correspond (the second point is highlighted in the capture below whereas the image is the first one):

@SarahBocognano Yes I know, it's how the carousel library choosed to display the selected image. It's weird to not highlight it, but they choose to shadow the selected one instead

[Archidoit]

Missing translations: 'Pictures management', 'in carousel' and 'update a picture'.

[SouadHadjiat]

all of this organizations part is in organization.graphql, maybe a merge issue ?

[SarahBocognano]

Yes It's a merge issue

[SouadHadjiat]

it's still a duplicate no? you don't need to remove it ?

[Archidoit]

What about making the boxes clickable ? (avoid to open the edition form)

@SarahBocognano As discussed with Julien, we choose to make the boxes clickable inline disabled to keep the consistency of the platform. We plan to make editable "lines" in the future, so that way we can avoid forms sometimes, but for now it was asked to be disabled

[Archidoit]

Edit an image that has an order from Picture Management
Remove the 'order'
Update
An error occurs

That's strange because you can have images without order, but when an image has an order, you can't remove it.

[Archidoit]

When no order, we don't see the tooltip when the mouse is over it

[Archidoit]

What about enable the sort of the images by order in the carousel? (it's only a suggestion)

[Archidoit]

Error when going to an entity 'Data' tab.
Steps to reproduce:

• Go to a malware overview (or an other entity).
• Go to the 'Data' tab
• An error occurs

[SouadHadjiat]

images in plural since it's an array.
Also, maybe it could be useful to have directly the avatarImage here, like this :

const images = cardData.images?.edges ?? [];
const avatarImage = (images.length > 0 && images[0]) ? images[0].node : null;

And then you could directly use avatarImage, and only test if it's defined or not. What do you think ?

[SouadHadjiat]

This component is generic and used for Malware, Campaign, Intrusion Sets, ... not only Threat Actors individuals. How does it work for them ?

[SouadHadjiat]

Same question here as for GenericAttackCard : is this method generic or specific for Threat Actors Individuals ? StixDomainObjectBookmark is a shared component.

[SouadHadjiat]

Do we need more than one country ? If we need only one, maybe it could be handled by ThreatActorIndividual resolver to return the country ?