Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Stix Meta Object details in Investigation graphs (#3986) #4003

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Aug 8, 2023

Github issue: #3986

To test the issue:

  • Go to an investigation graph.
  • Click on an entity that has meta relations (labels, markings, kill chain phase or external reference).
  • Expand the entity (via a button in the toolbar)
  • Click on a meta object. A details panel opens and it has an error.

@Archidoit Archidoit self-assigned this Aug 8, 2023
@SamuelHassine
Copy link
Member

@Archidoit I think this is also the case for kill chain phases and external references (all meta objects). Whether we find a way to display them properly or to discard them in a generic approach.

@Archidoit Archidoit marked this pull request as draft August 9, 2023 09:33
@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Aug 9, 2023
@Archidoit
Copy link
Member Author

@SamuelHassine indeed. I'm going to create a detail vue for the meta objects. Maybe I can also create a generic query (and a module) for stixMetaObjects. This will enable to do a single query for all the meta objects, and then display their attribute in the details part.

@Archidoit Archidoit marked this pull request as ready for review August 11, 2023 08:55
@Archidoit Archidoit marked this pull request as draft August 11, 2023 08:57
@Archidoit Archidoit changed the title [frontend] Marking and Label details in Investigation graphs (#3986) [frontend] Stix Meta Object details in Investigation graphs (#3986) Aug 11, 2023
@Archidoit Archidoit marked this pull request as ready for review August 11, 2023 09:12
Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅ Works fine

@Archidoit
Copy link
Member Author

PR ready for review

@yassine-ouaamou
Copy link
Member

All good for me 👍

@Archidoit Archidoit merged commit 4e358d0 into master Aug 16, 2023
6 checks passed
@Archidoit Archidoit deleted the issue/3986 branch August 16, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants