[backend] Workspace should have at least one valid admin (#3922) #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Archidoit
force-pushed
the
issue/3922
branch
2 times, most recently
from
f420a0f
to
36bbc26
Compare
|
Comment: If a user is deleted and he is the only admin of a workspace, the workspace will be unadministrable. This is a more global problem, that will be resolved in a future issue: #4026 |
yassine-ouaamou
approved these changes
Aug 10, 2023
|
Behaviour tested, code checked, PR approved! |
| .map((e) => e.id); | ||
| if (adminIds.includes(MEMBER_ACCESS_ALL)) { // everyone is admin | ||
| return true; | ||
| } |
There was a problem hiding this comment.
maybe add a condition here that checks that there is at least one member with admin right, before trying to resolve the admin ids, otherwise return false
like this :
if (adminIds.length == 0) {
return false
}
It's the condition we had before.
| const userIds = adminIds | ||
| .filter((id) => !groups.map((o) => o.id).includes(id) | ||
| && !organizations.map((o) => o.id).includes(id)) | ||
| .concat(groupsMembersIds, organizationsMembersIds); |
There was a problem hiding this comment.
groups.map((o) => o.id) and organizations.map((o) => o.id) are done inside the filter, maybe we could extract it before ? have organizationIds and groupIds, then use the include ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue: #3922
demo: see link in Teams