Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Knowledge graphs improvement + sightings details in investigation graphs (#4086) #4091

Merged
merged 7 commits into from
Aug 22, 2023

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Aug 17, 2023

Github issue: #4086

Notion page: https://www.notion.so/filigran/Investigation-graph-bugs-6ee6063b3c69421d9fb4f00361c5f8b8

PR content:

In investigation graphs:

  • disable StixMetaObject edition
  • add confidence level in StixDomainObject edition form

In knowledge and investigation graphs:

  • add sighting preview window
  • enable sighting edition from the graph
  • edition forms width set to 30% for homogeneity
  • fix empty description in observable details
  • add confidence level in entities preview window (except observables)
  • fix can’t edit a report description from the graph

In sighting overview:

  • edition form width set to 50% for homogeneity with other classic edition forms

@Archidoit Archidoit self-assigned this Aug 17, 2023
@Archidoit Archidoit linked an issue Aug 17, 2023 that may be closed by this pull request
@Archidoit Archidoit marked this pull request as draft August 17, 2023 13:19
@Archidoit Archidoit changed the title [frontend] sightings details in investigation graphs (#4086) [frontend] Graphs improvement + sightings details in investigation graphs (#4086) Aug 18, 2023
@Archidoit Archidoit marked this pull request as ready for review August 18, 2023 14:05
@Archidoit Archidoit changed the title [frontend] Graphs improvement + sightings details in investigation graphs (#4086) [frontend] Knowledge graphs improvement + sightings details in investigation graphs (#4086) Aug 18, 2023
@yassine-ouaamou yassine-ouaamou added the filigran team use to identify PR from the Filigran team label Aug 21, 2023
Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅ Everything works perfectly !

@@ -10,6 +10,17 @@ import useQueryLoading from '../../../../utils/hooks/useQueryLoading';

const useStyles = makeStyles((theme) => ({
drawerPaper: {
minHeight: '100vh',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation is missing on both screen (graph and not graph)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand which animation you're talking about

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture.15.webm

When the drawer is open/close

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why there is this behavior difference, I checked and there is no code difference between stix core relationships and sightings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that
It's a problem on my side
All good now, sorry

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's strange is that I have been able to reproduce the issue

@RomuDeuxfois RomuDeuxfois self-requested a review August 22, 2023 07:40
@SamuelHassine SamuelHassine merged commit c27d893 into master Aug 22, 2023
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the issue/4086 branch August 22, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sighting details are empty in investigation graphs
6 participants