Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Entity details in correlation views (#4065) #4096

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Aug 18, 2023

issue: #4065

PR content

In correlation views (of Grouping, Report, RFT, RFI and Incidents) :

  • add the possibility to view the entities details when clicking on an object.
  • possibility to view a basic-relationship details when clicking on an arrow
  • disable basic relationship edition button
  • fix bottom bar design (no more overlaps on the left)

Comment

If you can't populate the correlation view, it's normal, the view is not working well... It may be hard to test if you can't populate, the issue will be resolved later.

@Archidoit Archidoit self-assigned this Aug 18, 2023
@Archidoit Archidoit linked an issue Aug 18, 2023 that may be closed by this pull request
@SouadHadjiat SouadHadjiat self-requested a review August 21, 2023 10:27
@yassine-ouaamou yassine-ouaamou added the filigran team use to identify PR from the Filigran team label Aug 21, 2023
@Archidoit Archidoit force-pushed the issue/4065 branch 2 times, most recently from 5d9674c to ad79122 Compare August 23, 2023 07:30
@SarahBocognano
Copy link
Member

Still impossible to test locally on my part :(

@yassine-ouaamou
Copy link
Member

All good for me!
Able to view details of the entities and the relationships 👍
No edition possible 👍
No overlap 👍

@Archidoit Archidoit merged commit 54849a8 into master Aug 23, 2023
6 checks passed
@Archidoit Archidoit deleted the issue/4065 branch August 23, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to select objects in the Report's Correlation View
4 participants