[backend/frontend] Fix creation and edition of SHA512 in File Observable (#issue/3917) #4100
Conversation
| @@ -403,7 +403,7 @@ const StixCyberObservableEditionOverviewComponent = ({ | |||
| <Field | |||
| component={TextField} | |||
| variant="standard" | |||
| name="hashes.SHA-512" | |||
| name="hashes_SHA-512" | |||
| label={t('hash_sha-512')} | |||
There was a problem hiding this comment.
missing translation (or useless 't' if it shouldn't be translated)
There was a problem hiding this comment.
because I noticed the file attributes are never translated :
yassine-ouaamou
added
the
filigran team
|
Remaining error in WorkbenchFileContent.jsx : |
|
Peut-tu donner des exemples de valeurs valides pour les 'hashes' ? J'essaie de tester l'édition d'un stix file mais je ne sais pas trop quoi rentrer pour avoir un format valide. |
@Archidoit You can use alienvault for md5, sha1, sh256: https://otx.alienvault.com/browse/global/indicators?include_inactive=0&sort=-modified&page=1&limit=10&type=FileHash-MD5 |
|
I think it could be interesting if we translate: |
|
Comments fixed |
SarahBocognano
force-pushed
the
issue/3917
branch
from
edd6330
to
dc8ee30
Compare
|
The label is correct for all the languages except english where it is still hash_sha-* |
|
Can you also translate the attributes of StixFile edition form that are not? (maybe at least the ones with '_' in their name) @SarahBocognano : I'd rather not, because those are the direct attributes of the StixFile schema, and they not appears in the form |
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...