Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] refactor cards components (#4095) #4101

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Aug 18, 2023

Proposed changes

The issue was due to null "to" object in relationships

  • Refactor cards components to avoid code duplication : create GenericAttackCard component which represents all Malware, Campaign, Intrusion Sets and Threat Actors cards
  • Transform cards components to tsx

Related issues

Steps I used to reproduce the issue :

  • Create a new Sector
  • Go to a Threat Actor or Campaign or Malware or Intrusion Set
  • Add a relationship to a Sector (Knowledge -> Victimology => Add)
  • Back to the list : you should see your entity card with "targeted sector" displayed
  • Delete the sector by elastic search query (or change the marking of the sector and log with a user that doesn't have access to it)
  • Back to the list => error

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@yassine-ouaamou yassine-ouaamou added the filigran team use to identify PR from the Filigran team label Aug 21, 2023
@SouadHadjiat SouadHadjiat marked this pull request as ready for review August 22, 2023 14:57
@SamuelHassine SamuelHassine merged commit 3a547a4 into master Aug 23, 2023
4 of 6 checks passed
@SamuelHassine SamuelHassine deleted the issue/4095 branch August 23, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants