Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Add Threat-Actor icon #4128

Merged
merged 1 commit into from
Aug 22, 2023
Merged

[frontend] Add Threat-Actor icon #4128

merged 1 commit into from
Aug 22, 2023

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois commented Aug 21, 2023 •
edited

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@RomuDeuxfois RomuDeuxfois linked an issue Aug 21, 2023 that may be closed by this pull request
Missing icon for Threat Actors in Workbench #4099
Closed
@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Aug 21, 2023
SarahBocognano
SarahBocognano previously approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

@Archidoit
Copy link
Member

Archidoit commented Aug 21, 2023 •
edited

  • I have an icon now, but Threat Actor Group/indivdual are displayed differently according to how they have been added in the Workbench (via a file or via the + button) (see screenshots)
  • incorrect green icon (see screenshots)

image

image

@RomuDeuxfois
Copy link
Member Author

PR reworked

@yassine-ouaamou yassine-ouaamou dismissed their stale review August 22, 2023 08:29

We are not showing the right icon in a workbench

@RomuDeuxfois RomuDeuxfois merged commit 34edfaf into master Aug 22, 2023
6 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/4099 branch August 22, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouadHadjiat SouadHadjiat SouadHadjiat approved these changes

@yassine-ouaamou yassine-ouaamou yassine-ouaamou approved these changes

@Archidoit Archidoit Awaiting requested review from Archidoit

@SarahBocognano SarahBocognano Awaiting requested review from SarahBocognano

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing icon for Threat Actors in Workbench
5 participants
@RomuDeuxfois @Archidoit @SouadHadjiat @yassine-ouaamou @SarahBocognano