[frontend] fix relationship stop_time edition (#4133) #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archidoit
changed the title
tomibennett
reviewed
Aug 22, 2023
| @@ -275,6 +275,18 @@ Omit<StixCoreRelationshipEditionOverviewProps, 'queryRef'> | |||
| stixCoreRelationshipValidator, | |||
| ); | |||
|
|
|||
| // necessary for stop_time because the validator includes a reference to another value (start_time) | |||
There was a problem hiding this comment.
If the validator refers to the wrong value, should it be fixed?
There was a problem hiding this comment.
it's not a wrong value, you need it to compare start_time and stop_time
| @@ -383,7 +395,7 @@ Omit<StixCoreRelationshipEditionOverviewProps, 'queryRef'> | |||
| component={DateTimePickerField} | |||
| name="stop_time" | |||
| onFocus={editor.changeFocus} | |||
| onSubmit={editor.changeField} | |||
| onSubmit={handleSubmitFieldStopTime} | |||
There was a problem hiding this comment.
why doesn't it work like the other fields ? why did you need to add handleSubmitFieldStopTime ?
There was a problem hiding this comment.
the other fields don't call an other field for their validation
There was a problem hiding this comment.
the origin of the problem is the same as for an old issue whose brainstorm is here : https://www.notion.so/filigran/Can-t-update-end-date-of-an-event-3033-ae8c2ab25c564973b974dfb3c980c90d#3e295d32596d4da391830a004964244e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue: #4133