Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix backgroundTask filter issue #4137

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[backend] fix backgroundTask filter issue #4137

merged 1 commit into from
Aug 23, 2023

Conversation

yassine-ouaamou
Copy link
Member

@yassine-ouaamou yassine-ouaamou commented Aug 22, 2023

Proposed changes

  • Mapping properly the filterMode (AND/OR)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

To test this fix, you need to create a background task of deletion using a negative filter on Technical

  • Create a user "A"
  • Import a bunch of entites as "A"
  • Go to "Data" > "Entities"
  • Apply a filter on "Technical creator" in a way to exclude all the users except the entites of the user "A"
  • Select all the entites and delete them
  • The number shown on the top of the list (or in the background task popup must be the same as the number of entites in the background task screen
    Here are screeshots from the issue where you see different numbers:
    image

image

@yassine-ouaamou yassine-ouaamou linked an issue Aug 22, 2023 that may be closed by this pull request
@yassine-ouaamou yassine-ouaamou added the filigran team use to identify PR from the Filigran team label Aug 23, 2023
@yassine-ouaamou yassine-ouaamou self-assigned this Aug 23, 2023
@yassine-ouaamou yassine-ouaamou marked this pull request as ready for review August 23, 2023 07:02
Copy link
Member

@SarahBocognano SarahBocognano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅ Works Fine

@SamuelHassine SamuelHassine merged commit 14d6257 into master Aug 23, 2023
6 checks passed
@SamuelHassine SamuelHassine deleted the issue/4071 branch August 23, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background task for negative filter is not correctly computed
4 participants