[backend] Improve stix loader and stream relation resolution #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-julien
added
enterprise edition
| const toId = stixData.target_ref ?? stixData.where_sighted_refs[0]; | ||
| const hasFrom = missingMap.has(fromId) || cache.has(fromId); | ||
| const hasTo = missingMap.has(toId) || cache.has(toId); | ||
| if (!hasFrom || !hasTo) { |
There was a problem hiding this comment.
I am not sur this is exactly what we want
If there are in a platform
- a sector : marking RED
- a sector : marking GREEN
- a relationship between this two sectors : marking GREEN
- user A : marking GREEN
If user A modify the relationship, the modification is not displayed in the stream
There was a problem hiding this comment.
Its exactly what is expected. If both part of the relation is not accessible the relation must not be published.
| @@ -471,7 +472,7 @@ const loadElementsWithDependencies = async (context, user, elements, opts = {}) | |||
| const message = `From ${element.fromId} is ${validFrom}, To ${element.toId} is ${validTo}`; | |||
| logApp.warn(`Auto delete of invalid relation ${element.id}. ${message}`); | |||
| // Auto deletion of the invalid relation | |||
| await elDeleteElements(context, SYSTEM_USER, [element], storeLoadByIdWithRefs); | |||
| // await elDeleteElements(context, SYSTEM_USER, [element], storeLoadByIdWithRefs); | |||
There was a problem hiding this comment.
Why removing this ?
There are some side effects ?
There was a problem hiding this comment.
Just forgot to remove the comment after some testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is conditions where an auto sanity mode think that the relation should be deleted.
Its due to our process that doesnt not use system user to resolve to be sure about the situation.
Also improve the stream to not publish the relation if one of the from/to is not accessible.