-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Improve objects resolutions for container (#4153) #4159
Conversation
When I create an ObservedData from a domain name, it has the name of the domain name, then I add a note, there is no error anymore but the ObservedData name is now "empty". ===> update |
const data = args.all ? await paginateAllThings(context, user, types, R.assoc('filters', filters, args)) | ||
: await listThings(context, user, types, R.assoc('filters', filters, args)); | ||
const queryFilters = { ...args, filters, connectionFormat: false }; | ||
const elementsPromise = args.all ? listAllThings(context, user, types, queryFilters) : listThings(context, user, types, queryFilters); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we retrieve elements from another query rather than retrieve them from the relations ?
We can have const toIds = relations.map((rel) => rel.toId) and resolve toIds, no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a general problem of the current model. In order to support case of pagination/sorting/filtering we use the denormalized id of elements stored in rel_. Unfortunalty we miss the fact that storing also the direction was needed and so when we list through that part we have sometime to much elements.
I test this case and it's fixed now |
Tested 🆗 |
No description provided.