[frontend] Fix correlated cases is not working #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkha
reviewed
Oct 31, 2023
...i-platform/opencti-front/src/private/components/cases/case_incidents/CaseIncidentDetails.tsx
Outdated
Show resolved
Hide resolved
jpkha
reviewed
Oct 31, 2023
opencti-platform/opencti-front/src/private/components/analyses/reports/ReportDetails.jsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4818 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
jpkha
approved these changes
Nov 2, 2023
Kedae
requested changes
Nov 2, 2023
| @@ -233,7 +233,7 @@ const CaseIncidentDetails: FunctionComponent<CaseIncidentDetailsProps> = ({ | |||
| {t('Correlated cases')} | |||
| </Typography> | |||
| <List classes={{ root: classes.relatedContainers }}> | |||
| {expandable | |||
| {(data.relatedContainers?.edges && data.relatedContainers.edges.length >= 2) | |||
There was a problem hiding this comment.
You need to extract the filtering of the list before the return and check that this computed list as at least one element
…/ ReportDetails / CaseIncidentDetails / CaseRfiDetails / CaseRftDetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...