Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix infinite loader not working within a Drawer (#4792) #4821

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

labo-flg
Copy link
Member

@labo-flg labo-flg commented Oct 31, 2023

Proposed changes

  • fix padding of a list inside a drawer
  • fix infinite loading inside a drawer

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Comment on lines +773 to +777
SlideProps={{
// containerRef is forwarded to ListLinesContent so it listens to scroll events and load data with an InfiniteLoader
// we must target the element inside the Drawer that holds the scrolling = the Slide
ref: containerRef,
}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kedae this is the proper solution

MUI doc is clumsy but when you read between the lines...

@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Oct 31, 2023
@labo-flg labo-flg linked an issue Oct 31, 2023 that may be closed by this pull request
Copy link

codecov bot commented Oct 31, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@labo-flg labo-flg merged commit 72d338d into master Oct 31, 2023
8 checks passed
@labo-flg labo-flg deleted the issue/4792 branch October 31, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loading is broken on create relationships since new drawer
2 participants