New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Add quick export button in Report overview (#2515) #4831
Conversation
opencti-platform/opencti-front/src/private/components/common/files/FileExportViewer.tsx
Show resolved
Hide resolved
...m/opencti-front/src/private/components/common/stix_core_objects/StixCoreObjectFileExport.jsx
Outdated
Show resolved
Hide resolved
About the file |
.../opencti-front/src/private/components/common/stix_domain_objects/StixDomainObjectContent.jsx
Show resolved
Hide resolved
Yes I think we mentionned that in the future we could enrich the Content view with all exported files. We will rediscuss that after this chunk |
opencti-platform/opencti-front/src/private/components/analyses/reports/Report.jsx
Outdated
Show resolved
Hide resolved
Indeed need to fix this little style issue
And this one also |
...m/opencti-front/src/private/components/common/stix_core_objects/StixCoreObjectFileExport.jsx
Outdated
Show resolved
Hide resolved
...m/opencti-front/src/private/components/common/stix_core_objects/StixCoreObjectFileExport.jsx
Outdated
Show resolved
Hide resolved
...m/opencti-front/src/private/components/common/stix_core_objects/StixCoreObjectFileExport.jsx
Outdated
Show resolved
Hide resolved
.../opencti-front/src/private/components/common/stix_domain_objects/StixDomainObjectContent.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opencti-platform/opencti-front/src/private/components/common/files/FileLine.tsx
Outdated
Show resolved
Hide resolved
/> | ||
</Tooltip> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree on this one as it separate two distinct blocs of the DOM
opencti-platform/opencti-front/src/private/components/common/files/FileLine.tsx
Outdated
Show resolved
Hide resolved
.../opencti-front/src/private/components/common/stix_domain_objects/StixDomainObjectContent.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_domain_objects/StixDomainObjectContentFiles.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_domain_objects/StixDomainObjectContentFiles.jsx
Outdated
Show resolved
Hide resolved
/ task.task_expected_number) | ||
* 100, | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no indentation issue here. Just imbricated ternary conditions that make this aspect
@SouadHadjiat about your 3 points :
@SarahBocognano about button with no pointer cursor: it's because you have no connector to export pdf started and so the button is disabled. Yes it should be grey, done, point 1 of Souad 😁 |
Otherwise, everything works fine after the updates ! :) ✅ |
…or Task, Note, Externals references
795526b
to
b4333cc
Compare
Proposed changes
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...