Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix Empty TAXII Ingester User Reverts to Previous User instead of System (#4813) #4834

Merged
merged 3 commits into from Nov 8, 2023

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Nov 2, 2023

Proposed changes

  • Handle empty value

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Nov 2, 2023
@helene-nguyen helene-nguyen self-assigned this Nov 2, 2023
@SouadHadjiat SouadHadjiat changed the title [frontend] Fix Empty TAXII Ingester User Reverts to Previous User ins… [frontend] Fix Empty TAXII Ingester User Reverts to Previous User instead of System (#4813) Nov 3, 2023
@SouadHadjiat
Copy link
Member

SouadHadjiat commented Nov 3, 2023

When I empty the input, I can now see an empty user in the list, and if I just empty the input and close the update panel, when I reopen it it still displays my old user.

The only way I can set back to System user, is to select in the list the empty user.

Capture d'écran 2023-11-03 094700

Also, When I create a new ingester, and try to set a user, I will always see this empty user in the list first

@helene-nguyen helene-nguyen merged commit 2b6a9a2 into master Nov 8, 2023
6 checks passed
@helene-nguyen helene-nguyen deleted the issue/4813-fix branch November 8, 2023 15:34
Goumies pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty TAXII Ingester User Reverts to Previous User instead of System
4 participants