[frontend] Fix Adding a tag to a dashboard is not working (#4863)

[SarahBocognano]

Related issues

• Adding a tag to a dashboard is not working #4863

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ccd460) 0.00% compared to head (3dde352) 87.27%.
Report is 9 commits behind head on master.

❗ Current head 3dde352 differs from pull request most recent head 4c57a56. Consider uploading reports for the commit 4c57a56 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4875       +/-   ##
===========================================
+ Coverage        0   87.27%   +87.27%     
===========================================
  Files           0        3        +3     
  Lines           0      220      +220     
  Branches        0       55       +55     
===========================================
+ Hits            0      192      +192     
- Misses          0       28       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SarahBocognano]

Update: After a talk with the product team. Knowing that the app is not really responsive, we've decided to put the tags under the buttons. All comments have been resolved

[SamuelHassine]

Adding more than 5 tags displays the "More" button which is not working in this branch.

Also, I'm not sure about putting the tags below, which is not so user friendly for dashboards. I would prefer we hide any overflow on the line, even if only one tag is displayed. And have a button to open the rest.

[SarahBocognano]

Update: style problem fix, and I align the "More" tags button with the ones in aliases in entities

[helene-nguyen]

Canwe add more than 5 tags? The 'plus' button disappears and the 'more' button doesn't work

@helene-nguyen You're not supposed to have this visual. The more button is not there anymore, it is manage like the aliases.

[SamuelHassine]

And the "More" button should have a margin right to avoid to be closed to the orange button. Also alignment is not correct we should margin top negative to align with current right buttons position.

@SamuelHassine It's not a more button anymore, it is manage like the aliases. I'm not sure that the comment up matter because it's not align with the last version of this PR.

[marieflorescontact]

locally tested 👌

[helene-nguyen]

Locally tested too, everything seems good :)