Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] File indexing advanced configuration (#1483) #4882

Merged
merged 23 commits into from Nov 27, 2023

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Nov 10, 2023

Proposed changes

  • Add advanced configuration form for indexing (mime types, max file size, include global files, restrict to entity types)
  • Fix performance issues with files listing : list files to index without loading each file. Load files only if we want to index them.
  • Display progression bar

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@marieflorescontact marieflorescontact changed the title [backend] Implement reset file indexing [frontend/backend] File indexing advanced configuration (#1483) Nov 10, 2023
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Nov 10, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd0b6f8) 0.00% compared to head (5664b71) 87.27%.

❗ Current head 5664b71 differs from pull request most recent head 0fe126e. Consider uploading reports for the commit 0fe126e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4882       +/-   ##
===========================================
+ Coverage        0   87.27%   +87.27%     
===========================================
  Files           0        3        +3     
  Lines           0      220      +220     
  Branches        0       55       +55     
===========================================
+ Hits            0      192      +192     
- Misses          0       28       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact merged commit 718e89a into master Nov 27, 2023
6 checks passed
@marieflorescontact marieflorescontact deleted the issue/1483-2 branch November 27, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants