[backend] validate saved filters on create/edit (#4536) #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lerIdsToResolveForCache (#2686)
* with respect to isStixMatchFilterGroup capabilities
Archidoit
reviewed
Nov 14, 2023
| @@ -36,6 +37,11 @@ const checkFeedIntegrity = (input: FeedAddInput) => { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| // our stix matching is currently limited, we need to validate the input filters | |||
| if (input.filters && input.filters !== '{}') { | |||
There was a problem hiding this comment.
can input.filters be equal to {} ? I think it's undefined or of type FilterGroup (mode is compulsory etc)
There was a problem hiding this comment.
it can be apparently. I tested it, but don't remember the actual test case.
Well in fact this check is not useful, the validation would throw an error properly anyway..
Archidoit
force-pushed
the
issue/2686-preparation
branch
2 times, most recently
from
03a86b8
to
c34f8ba
Compare
|
Reviewed lived and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to validate each and every filter saved into the platform with respect to isStixMatchFilterGroup capabilities:
Proposed changes
Related issues
Further comments
Only for internal review in the "filter team".