[frontend] Keep html body attribute 'data-theme' in sync when changing theme (#4693) #4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lndrtrbn
commented
Nov 15, 2023
Comment on lines
+62
to
+75
| // Change the theme body attribute when the mode changes in | ||
| // the palette because some components like CKEditor uses this | ||
| // body attribute to display correct styles. | ||
| useEffect(() => { | ||
| const body = document.querySelector('body'); | ||
| if (body) { | ||
| const bodyMode = body.getAttribute('data-theme'); | ||
| const themeMode = `${theme.palette.mode}`; | ||
| if (bodyMode !== themeMode) { | ||
| body.setAttribute('data-theme', themeMode); | ||
| } | ||
| } | ||
| }, [theme]); | ||
|
|
There was a problem hiding this comment.
The code about fixing the issue.
The rest is to be able to use TypeScript.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4906 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 3 3
Lines 220 220
Branches 55 55
=======================================
Hits 192 192
Misses 28 28 ☔ View full report in Codecov by Sentry. |
jpkha
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Index.jsxin TypeScriptRelated issues
Checklist