Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Changes to helper text for search widgets #4915

Merged

Conversation

ParamConstructor
Copy link
Contributor

Proposed changes

This PR updates the helper text in the search widgets of OpenCTI to more clearly convey what the search target of the widget is:

  • Top Right widget now says 'Search OpenCTI...' since this widget searches the whole platform
  • Top Left widget nested within a section now says 'Search these results....'
  • The SearchInput component was updated to accept a 'placeholder' value which is defaulted to the 'Search these results' option but can be overload - like in TopBar to be replaced with 'Search OpenCTI'

Related issues

  • None

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d040085) 87.27% compared to head (626afb1) 87.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4915   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files           3        3           
  Lines         220      220           
  Branches       55       55           
=======================================
  Hits          192      192           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit 076c0a6 into OpenCTI-Platform:master Nov 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants